[Doc] Fix react-admin's vite tutorial CSS setup #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiXSL
changed the title
WiXSL
commented
Nov 21, 2022
| <App /> | ||
| </React.StrictMode> | ||
| ) | ||
| // in src/index.css |
There was a problem hiding this comment.
There are two more differences between simple project's index.html (which uses vite) and this tutorial's index.html
1- Script to adds the Roboto font
2- <script>window.global = window</script>
I don't know how relevant these are for a tutorial, let me know if I should add them as part of the tutorial to this PR
WiXSL
changed the title
fzaninotto
approved these changes
Nov 21, 2022
|
As for the Roboto Font, you're right, we should add it back. I suggest we use the method described in the MUI doc. Would you mind opening another PR for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8407