Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prop-types validation for TabbedFormView's toolbar prop #8436

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Fix prop-types validation for TabbedFormView's toolbar prop #8436

merged 1 commit into from
Nov 27, 2022

Conversation

kosmotema
Copy link
Contributor

Currently, when specifying the toolbar prop of the TabbedForm component false, React issues a warning:

Warning: Failed prop type: Invalid prop `toolbar` of type `boolean` supplied to `TabbedFormView`, expected a single ReactElement.

This PR fixes PropTypes validation for the toolbar prop, allowing the false value to be used like:

<TabbedForm toolbar={false}>...</TabbedForm>

@kosmotema kosmotema force-pushed the tabbed-form-view-toolbar-prop-types branch from 0e874c3 to 5a3e106 Compare November 25, 2022 22:11
WiXSL
WiXSL approved these changes Nov 26, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fzaninotto fzaninotto merged commit df2d857 into marmelab:master Nov 27, 2022
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.5.3 milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@WiXSL WiXSL WiXSL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kosmotema @fzaninotto @WiXSL