Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <FormDataConsumer> usage with Field children #8445

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Fix <FormDataConsumer> usage with Field children #8445

merged 3 commits into from
Nov 29, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 29, 2022

Fixes #8427

@WiXSL WiXSL added the RFR Ready For Review label Nov 29, 2022
slax57
slax57 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes.

I would just suggest changing the PR title to something more explicit. For instance something like:
Fix <SimpleFormIterator> example on how to work with Fields, and remove confusing warning in <FormDataConsumer>

@djhi djhi changed the title Fix FormDataConsumer warning Fix <SimpleFormIterator> example on how to work with Fields, and remove confusing warning in <FormDataConsumer> Nov 29, 2022
djhi
djhi reviewed Nov 29, 2022
View reviewed changes
docs/SimpleFormIterator.md
<Labeled label="Url">
<TextField source={getSource('url')} />
<TextField source="url" record={scopedFormData} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the removal of getSource ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this solution was tested in the context of this PR: #8359 (have a look at the comments)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean we don't need getSource anymore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need it for inputs

@fzaninotto fzaninotto changed the title Fix <SimpleFormIterator> example on how to work with Fields, and remove confusing warning in <FormDataConsumer> Fix <FormDataConsumer> usage Field children Nov 29, 2022
@fzaninotto fzaninotto changed the title Fix <FormDataConsumer> usage Field children Fix <FormDataConsumer> usage with Field children Nov 29, 2022
@fzaninotto fzaninotto merged commit 5ff83c3 into master Nov 29, 2022
@fzaninotto fzaninotto deleted the fix-form-data-consumer-warning branch November 29, 2022 17:22
@fzaninotto fzaninotto added this to the 4.6 milestone Nov 29, 2022
@WiXSL WiXSL mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

Fields are not reactive when used inside SimpleFormIterator
4 participants
@WiXSL @fzaninotto @djhi @slax57