Add /login-callback route and optional new authProvider.handleLoginCalback() method
#8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nCalback` method ## Problem When using third party services such as Auth0, you currently need to setup a custom route and work around the authProvider methods. ## Solution Introduce a new route at `/login-callback` that can be set as the callback endpoint for third party authentication services. This route will call the new `handleLoginCallback` optional method of the `AuthProvider` then redirect to the home page by default.
fzaninotto
requested changes
Dec 1, 2022
| When using external authentication services such as those implementing OAuth, you usually need a callback route. React-admin provides a default one at `/login-callback`. It will call the `AuthProvider.handleLoginCallback` method | ||
| that may validate the params received from the URL and redirect users to any page (the home page by default) afterwards. | ||
|
|
||
| It's up to you to decide when to redirect users to the third party authentication service, for instance: |
There was a problem hiding this comment.
This is a bit confusing. Could you elaborate?
There was a problem hiding this comment.
I don't get what's confusing
There was a problem hiding this comment.
I don't see why this section occurs here. It has nothing to do with the login callback
There was a problem hiding this comment.
Should I introduce a new dedicated page to third party authentication services ?
There was a problem hiding this comment.
at least a section in the Authentication introduction
There was a problem hiding this comment.
This is the authentication introduction page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
fzaninotto
requested changes
Dec 6, 2022
| When using external authentication services such as those implementing OAuth, you usually need a callback route. React-admin provides a default one at `/login-callback`. It will call the `AuthProvider.handleLoginCallback` method | ||
| that may validate the params received from the URL and redirect users to any page (the home page by default) afterwards. | ||
|
|
||
| It's up to you to decide when to redirect users to the third party authentication service, for instance: |
There was a problem hiding this comment.
I don't see why this section occurs here. It has nothing to do with the login callback
slax57
requested changes
Dec 6, 2022
slax57
approved these changes
Dec 7, 2022
slax57
approved these changes
Dec 7, 2022
djhi
commented
Dec 7, 2022
fzaninotto
approved these changes
Dec 12, 2022
|
Awesome! |
fzaninotto
added a commit
that referenced
this pull request
Dec 12, 2022
Seojun-Park
pushed a commit
to Seojun-Park/react-admin
that referenced
this pull request
Dec 19, 2022
Seojun-Park
pushed a commit
to Seojun-Park/react-admin
that referenced
this pull request
Dec 19, 2022
Seojun-Park
pushed a commit
to Seojun-Park/react-admin
that referenced
this pull request
Dec 19, 2022
Seojun-Park
pushed a commit
to Seojun-Park/react-admin
that referenced
this pull request
Dec 19, 2022
fzaninotto
changed the title
handleLoginCalback method/login-callback route and optional new authProvider.handleLoginCalback() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using third party services such as Auth0, you currently need to setup a custom route and work around the authProvider methods.
Solution
Introduce a new route at
/login-callbackthat can be set as the callback endpoint for third party authentication services. This route will call the newhandleCallbackoptional method of theAuthProviderthen redirect to the home page by default.Tasks