Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AutocompleteArrayInput when value is not an array #8608

Merged
merged 1 commit into from Jan 31, 2023
Merged

Fix AutocompleteArrayInput when value is not an array #8608

merged 1 commit into from Jan 31, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jan 30, 2023

Supersedes #8605

@djhi djhi added the RFR Ready For Review label Jan 30, 2023
@djhi djhi mentioned this pull request Jan 30, 2023
Closed
slax57
slax57 requested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally I approve and like the new tests, but shouldn't we also add tests for the null and undefined cases? Since after all, that's what the nullish coalesce checks for.

@fzaninotto fzaninotto merged commit 8a0c81c into master Jan 31, 2023
@fzaninotto fzaninotto deleted the fix-autocompletearrayinput branch January 31, 2023 08:57
@fzaninotto fzaninotto added this to the 4.7.3 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 requested changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.7.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djhi @slax57 @fzaninotto