Fix NumberInput should support entering a decimal number with a transitory invalid value #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itory invalid value
slax57
commented
Jan 30, 2023
| 'resources.posts.fields.views' | ||
| ) as HTMLInputElement; | ||
| fireEvent.focus(input); | ||
| await userEvent.type(input, '0.01', { delay: 100 }); |
There was a problem hiding this comment.
For some reason I could not replicate this test using a comma ('0,01') because it fails.
But I have tested manually and it works fine with a comma, both on Desktop and Mobile.
Could be an issue with the locale in Jest being different from the locale of my computer.
fzaninotto
requested changes
Jan 30, 2023
| } | ||
| hasFocus.current = false; | ||
| const stringValue = format(field.value); | ||
| setValue(value => (value !== stringValue ? stringValue : value)); |
There was a problem hiding this comment.
I don't understand why you need to do that. onChange already sets the value, doesn't it?
There was a problem hiding this comment.
OK, understood: the use case is: a user enters "0.0" and blurs. The form value is "0", but the displayed value is different - and this is misleading. Updating the displayed value based on the form value helps the user know what's going to be submitted.
| 'resources.posts.fields.views' | ||
| ) as HTMLInputElement; | ||
| fireEvent.focus(input); | ||
| await userEvent.type(input, '0.01', { delay: 100 }); |
fzaninotto
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8593