Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vite for the CRM demo #8696

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Use Vite for the CRM demo #8696

merged 2 commits into from
Mar 9, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Mar 2, 2023

No more CRA. Our yarn.lock got slimmer

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🙂

However I'm having a weird issue when running the CRM demo locally.
The 'loading state' spinner in the AppBar keeps spinning for a while, and then I get this error in the console:

Unknown method
overrideMethod	@	react_devtools_backend.js:2655
onError	@	query.js:356
reject2	@	retryer.js:67
(anonymous)	@	retryer.js:132

Seems to be related to the react devtools, which is weird, but I don't see it in the 'prod' demo, and I tried to refresh the page and all, still same result.

Do you see it on your end too?

@slax57
Copy link
Contributor

slax57 commented Mar 3, 2023

FI it also happens when running yarn build and yarn preview

@djhi
Copy link
Contributor Author

djhi commented Mar 3, 2023

This problem already exists on the deployed demo: https://marmelab.com/react-admin-demo/.

Something is calling the getPermissions method but the authProvider throws the above error

@slax57 slax57 added this to the 4.8.3 milestone Mar 9, 2023
@slax57 slax57 merged commit 743362a into master Mar 9, 2023
@slax57 slax57 deleted the crm-vite branch March 9, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants