Fix: some components are translating labels twice #8700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
reviewed
Mar 3, 2023
djhi
commented
Mar 7, 2023
djhi
commented
Mar 7, 2023
slax57
requested changes
Mar 7, 2023
djhi
commented
Mar 7, 2023
djhi
commented
Mar 7, 2023
slax57
approved these changes
Mar 7, 2023
slax57
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some components were translating labels twice. Besides the validation messages were translated twice as well. Fixing this requires a potential breaking change: when using the
InputHelperTextdirectly, the error message isn't translated anymore unless it's an object with amessageproperty. I believe this is a very rare usage if it even exists.FIxes #8662