Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SelectArrayInput does not display its label correctly in outlined variant #8705

Conversation

sebastianbuechler
Copy link
Contributor

@sebastianbuechler sebastianbuechler commented Mar 4, 2023

After receiving an answer from the MUI team (mui/material-ui#36164) I open the fix for the original issue in #8465 here. For better testing, I added the two remaining variants of the SelectArrayInput into the storybook here.

@sebastianbuechler sebastianbuechler changed the title Fix/set-correct-label-for-multi-select-input Fix/set-correct-label-for-select-array-input Mar 4, 2023
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 added this to the 4.8.3 milestone Mar 6, 2023
@slax57 slax57 merged commit c6591e3 into marmelab:master Mar 6, 2023
@slax57 slax57 changed the title Fix/set-correct-label-for-select-array-input Fix SelectArrayInput does not display its label correctly in outlined variant Mar 6, 2023
@sebastianbuechler
Copy link
Contributor Author

@slax57 Thank you, really enjoy working with react-admin!

@WiXSL
Copy link
Contributor

WiXSL commented Mar 23, 2023

This fixes #8498

@slax57
Copy link
Contributor

slax57 commented Mar 24, 2023

You're 100% right @WiXSL , thanks for pointing that out! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants