Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Convert GIF files to WebM #8767

Merged
merged 10 commits into from Apr 26, 2023
Merged

[Doc] Convert GIF files to WebM #8767

merged 10 commits into from Apr 26, 2023

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Mar 24, 2023

Convert GIF files to WebM to reduce assets size.
Total GIF files size: 44.9 MiB
Total WebM files size: 16.9 MiB
Reduced assets size by 62.41 %!

Todo

  • Discuss if we should keep the GIF files for now or not
  • Fix TimeInput.md
  • Needs more testing
  • Improve video quality
  • Use CSS instead of repeating the styles
  • Fine-tune the video quality to better optimize assets size

@fzaninotto
Copy link
Member

Great! But the compression is a bit too aggressive, and artifacts are visible.

I tested on the features page, mostly the saved queries gif.

@slax57 slax57 added WIP Work In Progress and removed RFR Ready For Review labels Apr 7, 2023
docs/css/style-v14.css Show resolved Hide resolved
@fzaninotto
Copy link
Member

needs rebase

@fzaninotto
Copy link
Member

fzaninotto commented Apr 11, 2023

The quality is better!

But:

  • I'm surprised that the size reduction isn't more dramatic
  • Some webm files are larger than their GIF counterpart (e.g. the main video in ArrayInput.md)
  • Some webm files are still super large (e.g. datagrid_expand), probably because their resolution is too high

I think we need to tweak the video quality a bit more towards compression.

@slax57 slax57 removed the RFR Ready For Review label Apr 12, 2023
@slax57 slax57 added the WIP Work In Progress label Apr 12, 2023
@slax57
Copy link
Contributor Author

slax57 commented Apr 25, 2023

I've updated the WebM files with the following changes:

  • CRF set to 24
  • Maximum FPS set to 15
  • Maximum video resolution set to 1920x1080

With these changes, the assets size was reduced by 62.41 %, hopefully with not too much impact on quality 🙂

@fzaninotto fzaninotto merged commit e05a6c0 into master Apr 26, 2023
5 checks passed
@fzaninotto fzaninotto deleted the gif-to-webm branch April 26, 2023 08:26
@fzaninotto
Copy link
Member

Awesome!

@fzaninotto fzaninotto modified the milestones: 4.9.5, 4.10.0 Apr 26, 2023
@slax57 slax57 mentioned this pull request May 17, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants