Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] add missing prop of layout #8777

Merged
merged 3 commits into from
Mar 31, 2023
Merged

[Doc] add missing prop of layout #8777

merged 3 commits into from
Mar 31, 2023

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Mar 29, 2023

No description provided.

@djhi djhi changed the title [doc] add missing prop of layout [Doc] add missing prop of layout Mar 29, 2023
slax57
slax57 requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

Just like the other props, it should also have its dedicated section below, showing an example of usage.

docs/Layout.md Outdated Show resolved Hide resolved
@smeng9 @slax57
Update docs/Layout.md
6672b59 
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
@smeng9 smeng9 requested a review from slax57 March 30, 2023 11:20
slax57
slax57 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 added the RFR Ready For Review label Mar 31, 2023
@slax57 slax57 added this to the 4.9.1 milestone Mar 31, 2023
@slax57 slax57 merged commit efa2964 into marmelab:master Mar 31, 2023
@slax57 slax57 mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smeng9 @slax57