Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Fix UpdateParams id type doesn't use generic type #8782

Merged
merged 2 commits into from Mar 31, 2023
Merged

[TypeScript] Fix UpdateParams id type doesn't use generic type #8782

merged 2 commits into from Mar 31, 2023
+2 −2

Conversation

zhujinxuan
Copy link
Contributor

Update a type definition to make UpdateParams is consistent with the definition in GetOne and GetMany. Similar to #8208

Because UpdateParams includes previousData: T. So I think we shall have T extends RaRecord to fit the type of previousData.

@slax57 slax57 added the RFR Ready For Review label Mar 31, 2023
@slax57 slax57 added this to the 4.9.1 milestone Mar 31, 2023
@slax57 slax57 merged commit b51ebdf into marmelab:master Mar 31, 2023
7 checks passed
@slax57
Copy link
Contributor

slax57 commented Mar 31, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhujinxuan @slax57