Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useReferenceArrayInputController does not pass meta to getMany #8803

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Apr 4, 2023

Fix #8772

@fzaninotto
Copy link
Member

So we pass the same meta prop to useGetMany and useGetList? Isn't it going to break things?

@slax57
Copy link
Contributor

slax57 commented Apr 4, 2023

So we pass the same meta prop to useGetMany and useGetList? Isn't it going to break things?

In theory it indeed could be a BC for some (pretty specific) use-cases.

However, if my recollection is correct I believe we had the same discussion with the (EE) TreeController, and we figured it was best to pass the meta parameter everywhere and let the dataProvider decide where to use it or not. So in this regard it would improve the consistency.

Hence I'm in favor of this change.

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@fzaninotto fzaninotto merged commit f519477 into master Apr 4, 2023
@fzaninotto fzaninotto deleted the fix-reference-array-input-meta branch April 4, 2023 19:40
@fzaninotto fzaninotto added this to the 4.9.2 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing meta in getMany dataprovider function when using ReferenceArrayInput
3 participants