[Minor BC] Fix <Datagrid> does not apply className to its root element
#8804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be moved to next |
slax57
force-pushed
the
Datagrid-className
branch
from
4019fbe
to
c351ce4
Compare
slax57
changed the title
<Datagrid> does not apply className to its root element<Datagrid> does not apply className to its root element
slax57
changed the title
<Datagrid> does not apply className to its root element<Datagrid> does not apply className to its root element
djhi
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
<Datagrid>does not applyclassNameto its root element, but rather to its nestedTableelement.This creates a discrepancy between styles applied via
sxand styles applied viastyled.This is among others visible with the (EE)
<EditableDatagrid>component.Solution
sxandclassNameshould be applied to the same component, i.e.<DatagridRoot>.This change is technically a BC. But it should be really minor as it would affect only people that use
styledto apply styles to theDatagridcomponent. People applying styles viasxshouldn't be affected.Screenshots (of the added story)
Before
After