Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update chinese(zh) locale package #8813

Merged
merged 2 commits into from Apr 11, 2023

Conversation

haxqer
Copy link
Contributor

@haxqer haxqer commented Apr 6, 2023

chen4w/ra-language-chinese unable to support the latest ReactAdmin version.
The new version of RA has added some fields.

haxqer/ra-language-chinese support the latest ReactAdmin version.

Comment on lines 17 to 18
- Chinese (`zh`): [chen4w/ra-language-chinese](https://github.com/chen4w/ra-language-chinese)
- Chinese (`zh`): [haxqer/ra-language-chinese](https://github.com/haxqer/ra-language-chinese)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference with the existing package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chen4w/ra-language-chinese unable to support the latest ReactAdmin version.
The new version of RA has added some fields.

haxqer/ra-language-chinese support the latest ReactAdmin version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, can you please remove the old one then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haxqer haxqer requested a review from djhi April 10, 2023 02:45
@djhi djhi added this to the 4.9.2 milestone Apr 11, 2023
@djhi djhi merged commit ccbaf7f into marmelab:master Apr 11, 2023
2 checks passed
@djhi djhi changed the title add chinese(zh) locale [Doc] Update chinese(zh) locale Apr 11, 2023
@djhi djhi changed the title [Doc] Update chinese(zh) locale [Doc] Update chinese(zh) locale package Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants