Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite redirection loop in useHandleCallback #8861

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix infinite redirection loop in useHandleCallback #8861

merged 1 commit into from
Apr 27, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Apr 27, 2023

The default AuthCallback handles the error by showing a message.
The previous onError was preventing that and triggered an infinite loop

@djhi djhi added the RFR Ready For Review label Apr 27, 2023
@slax57 slax57 added this to the 4.9.5 milestone Apr 27, 2023
@slax57 slax57 merged commit 259b46e into master Apr 27, 2023
@slax57 slax57 deleted the fix-infinite-auth-callback-loop-on-error branch April 27, 2023 09:58
@fzaninotto fzaninotto modified the milestones: 4.9.5, 4.10.0 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djhi @slax57 @fzaninotto