Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Fix sidebar props #8887

Merged
merged 2 commits into from May 10, 2023
Merged

[typescript] Fix sidebar props #8887

merged 2 commits into from May 10, 2023

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented May 6, 2023

fix types for sidebar in layout so we can pass custom components that uses sidebar props

djhi
djhi requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linter warning? Thanks!

smeng9
smeng9 commented May 10, 2023
View reviewed changes
Copy link
Contributor Author

@smeng9 smeng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix linter warning

@smeng9 smeng9 requested a review from djhi May 10, 2023 01:42
@djhi
Copy link
Contributor

djhi commented May 10, 2023

Thanks!

@djhi djhi merged commit 764dd0d into marmelab:master May 10, 2023
9 checks passed
@djhi djhi added this to the 4.10.3 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
TypeScript
Projects
None yet
Milestone
4.10.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smeng9 @djhi