Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <SaveButton> spinner while submitting #8920

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix <SaveButton> spinner while submitting #8920

merged 1 commit into from
May 17, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented May 17, 2023 •
edited
Loading

Before

image

After

image

@fzaninotto fzaninotto added the RFR Ready For Review label May 17, 2023
djhi
djhi approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicer indeed 👍

@djhi djhi merged commit c4c57dc into master May 17, 2023
8 checks passed
@djhi djhi deleted the fix-savebutton-submitting-ui branch May 17, 2023 13:36
@djhi djhi added this to the 4.10.4 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.10.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fzaninotto @djhi