Upgrade to TS 5 #8937
Merged
Upgrade to TS 5 #8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
reviewed
Jun 23, 2023
There was a problem hiding this comment.
I still have this warning when running make lint:
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0
YOUR TYPESCRIPT VERSION: 5.1.3
Please only submit bug reports when using the officially supported version.
=============
Do you think we could try to get rid of it as well?
| "extends": ["react-app", "plugin:prettier/recommended"], | ||
| "plugins": [ | ||
| "@typescript-eslint", |
There was a problem hiding this comment.
FMI, why did you disable this plugin?
package.json
Outdated
Comment on lines
39
to
40
| "@typescript-eslint/eslint-plugin": "^5.59.7", | ||
| "@typescript-eslint/parser": "^5.59.7", |
djhi
commented
Jun 23, 2023
| { | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "warnOnUnsupportedTypeScriptVersion": false |
There was a problem hiding this comment.
We use version 5.1.3 when latest supported is 5.1.0. It will be supported soon but we're safe anyway
djhi
commented
Jun 23, 2023
Comment on lines
+81
to
+83
| "@typescript-eslint/typescript-estree": "^5.60.0", | ||
| "@typescript-eslint/parser": "^5.60.0", | ||
| "@typescript-eslint/eslint-plugin": "^5.60.0", |
There was a problem hiding this comment.
This is required because of eslint-config-react-app which has not been updated in 2 years. We would probably be better of with our own config
slax57
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.