[Doc] Fix NextJS tutorial for the latest version of create-next-app #8938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
May 23, 2023
| // build the CRUD request based on the incoming request | ||
| const url = `${process.env.SUPABASE_URL}/rest/v1/${requestUrl}`; | ||
| const options = { | ||
| const options: RequestInit = { |
There was a problem hiding this comment.
This TS annotation won't work with a jsx syntax highlighting
fzaninotto
reviewed
May 23, 2023
| @@ -12,7 +12,7 @@ React-admin runs seamlessly on [Next.js](https://nextjs.org/), with minimal conf | |||
| Let's start by creating a new Next.js project called `nextjs-react-admin`. | |||
|
|
|||
| ```bash | |||
| npx create-next-app --ts nextjs-react-admin --use-yarn | |||
| npx create-next-app@latest next-admin --ts --use-yarn --eslint --no-tailwind --no-src-dir --no-app --import-alias "@/*" | |||
There was a problem hiding this comment.
Can't we adapt the tutorial to work for the default setup instead?
There was a problem hiding this comment.
What is the default setup?
There was a problem hiding this comment.
I'm not sure ;)
It's just that the --no-src-dir --no-app feels like we're opting out of the improvements of Netx.js 13. Or am I mistaken?
There was a problem hiding this comment.
It's answering no at a question asked by the CLI, just like the --no-tailwind. You either opt in or out for each question with a flag or the CLI will ask it
fzaninotto
changed the title
fzaninotto
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.