Fix <Admin> should call authProvider.getPermissions only when given a child function
#9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Jun 13, 2023
packages/ra-core/src/core/useConfigureAdminRouterFromChildren.tsx
Outdated
Show resolved
Hide resolved
djhi
requested changes
Jun 13, 2023
packages/ra-core/src/core/useConfigureAdminRouterFromChildren.tsx
Outdated
Show resolved
Hide resolved
djhi
requested changes
Jun 13, 2023
djhi
changed the title
djhi
reviewed
Jun 13, 2023
Comment on lines
33
to
34
| const role = localStorage.getItem('permissions'); | ||
| return role ? Promise.resolve(role) : Promise.reject(); |
There was a problem hiding this comment.
IMO you should just resolve with undefined as we don't set those permissions anywhere
djhi
approved these changes
Jun 14, 2023
slax57
changed the title
<Admin> should call authProvider.getPermissions only when given a child function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a React Admin App with
create-react-admin, and choosing to add anauthProvider, the provider is created with this method:getPermissions: () => Promise.reject("Unknown method"),.This leads to an error log in browser devtools console (e.g:
Unknown method), even the app doesn't need permission anywhere.Reproduce:
create-react-adminFix: CallauthProvider.getPermissionsonly when a child function exist and only when the hookusePermissionsis used in the application.Fix: change
authProvidertemplate increate-react-adminpackage