Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix missing constant in List Tutorial example #9032

Merged
merged 3 commits into from Jun 20, 2023
Merged

[Doc] Fix missing constant in List Tutorial example #9032

merged 3 commits into from Jun 20, 2023

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Jun 20, 2023 •
edited

const sort was not defined but used in <Datagrid data={data} sort={sort}> in the tutorial

@adguernier adguernier added the RFR Ready For Review label Jun 20, 2023
fzaninotto
fzaninotto requested changes Jun 20, 2023
View reviewed changes
docs/ListTutorial.md Outdated Show resolved Hide resolved
fzaninotto
fzaninotto requested changes Jun 20, 2023
View reviewed changes
docs/ListTutorial.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 3d26bce into master Jun 20, 2023
5 checks passed
@fzaninotto fzaninotto deleted the doc-missing-constante-in-code-snippets branch June 20, 2023 16:15
@fzaninotto fzaninotto added this to the 4.11.4 milestone Jun 20, 2023
@fzaninotto fzaninotto changed the title [Doc] Add missing constant in code snippets [Doc] Fix missing constant in List Tutorial example Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
documentation RFR Ready For Review
Projects
None yet
Milestone
4.11.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adguernier @fzaninotto