Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Input components add a bottom margin even when helperText is false #9037

Merged
merged 17 commits into from
Jun 22, 2023
Merged

Fix Input components add a bottom margin even when helperText is false #9037

merged 17 commits into from
Jun 22, 2023

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Jun 21, 2023 •
edited
Loading

related to #8830 and #8829

@adguernier adguernier added the WIP Work In Progress label Jun 21, 2023
@adguernier adguernier added RFR Ready For Review and removed WIP Work In Progress labels Jun 21, 2023
@adguernier adguernier requested review from djhi and slax57 June 21, 2023 13:57
@djhi djhi added this to the 4.11.4 milestone Jun 21, 2023
@adguernier adguernier requested a review from slax57 June 22, 2023 07:48
@djhi djhi merged commit 1590655 into master Jun 22, 2023
10 checks passed
@djhi djhi deleted the fix-remove-helper-text-if-false branch June 22, 2023 09:00
@fzaninotto fzaninotto changed the title Prevent render InputHelperText if helperText props is false in Input components Fix Input components add a bottom margin even when helperText is false Jun 22, 2023
@fzaninotto fzaninotto mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.11.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adguernier @djhi @slax57