Fix Fields Record Type Parameter #9092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
added
RFR
slax57
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Code looks good to me.
However:
- I see you kept a default type to
anyfor all methods and components linked to Create (because contrary to the others it defaults toRaRecordwithout theidfield). Can't we improve these default types too? - I tried to compile the EE packages with this version and I got weirds TS errors with ra-navigation. You might want to investigate them to make sure this is not a regression that might impact our users
|
This should also fix #9102 |
djhi
changed the title
djhi
changed the title
fzaninotto
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9102