Fix package.json should mention peer dependency on react-is
#9201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/marmelab/react-admin/blob/83dc1d61f0d7efaafebb57885d6b55f78509b581/packages/ra-ui-materialui/src/form/FormTabHeader.tsx has an import from `react-is`, but it is not declared in `package.json` This was causing errors in my rollup build. I cannot be sure this is the right fix - for my project, I had to add this in my `.yarmrc.yml`: ``` packageExtensions: "ra-ui-materialui@*": dependencies: "react-is": "*" ``` Here, `peerDependencies` doesn't work, but for `package.json` I think it makes sense to put it there.
djhi
requested changes
Aug 21, 2023
|
Hrm, the yarn update updated some other dependencies at all. Is that okay, or do I somehow have to cherry pick just the |
|
I took the liberty to update your branch, and fix the |
slax57
changed the title
package.json should mention peer dependency on react-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/marmelab/react-admin/blob/83dc1d61f0d7efaafebb57885d6b55f78509b581/packages/ra-ui-materialui/src/form/FormTabHeader.tsx has an import from
react-is, but it is not declared inpackage.jsonThis was causing errors in my rollup build. I cannot be sure this is the right fix - for my project, I had to add this in my
.yarmrc.yml:Here,
peerDependenciesdoesn't work, but forpackage.jsonI think it makes sense to put it there.