Reduce top margin of <TopToolbar> to move content up when there is no filter
#9232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Aug 29, 2023
| @@ -63,18 +63,16 @@ export interface ListToolbarProps | |||
|
|
|||
| const PREFIX = 'RaListToolbar'; | |||
|
|
|||
| const Root = styled(Toolbar, { | |||
| const Root = styled('div', { | |||
There was a problem hiding this comment.
The ListToolbar renders ListActions, which itself renders TopToolbar, which also renders a Toolbar. So there was a toolbar inside a toolbar, with added margin and padding... not really necessary.
fzaninotto
changed the title
<TopToolbar> min height to move content up when there is no filter<TopToolbar> to move content up when there is no filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In List views, if there is no filter, some space is wasted between the app bar and the list. This is especially visible when using alternative layouts.
Solution
Remove the min height of the
TopToolbar(which applies to all pages) and add it to theFilterForminstead, so that the top toolbar remains tall enough when there are filters.As a consequence:
Before
After