Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fix preferences are shared between demos #9264

Merged
merged 2 commits into from Sep 12, 2023
Merged

Conversation

mchaffotte
Copy link
Contributor

Problem

If this application is installed on the same domain as other demo applications. The store is overridden. The data are not synchronized anymore.

Solution

Add a custom store with a dedicated application key.

@mchaffotte mchaffotte added the RFR Ready For Review label Sep 8, 2023
@fzaninotto fzaninotto changed the title [Typescript] Prevent store overrides [Demo] Fix preferences are shared between demos Sep 11, 2023
examples/demo/src/App.tsx Outdated Show resolved Hide resolved
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@djhi djhi added this to the 4.14.1 milestone Sep 12, 2023
@djhi djhi merged commit 03f9825 into master Sep 12, 2023
11 checks passed
@djhi djhi deleted the fix-demo-store-overrides branch September 12, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants