Fix <PrevNextButton> default style
#9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Sep 18, 2023
| @@ -108,7 +115,7 @@ export const PrevNextButtons = <RecordType extends RaRecord = any>( | |||
|
|
|||
| if (isLoading) { | |||
| return ( | |||
| <Box minHeight={theme => theme.spacing(4)}> | |||
There was a problem hiding this comment.
I can't keep consistent height between the empty / loading / loaded versions unless I switch to pixels
fzaninotto
changed the title
<PrevNextButton> styling<PrevNextButton> default style
djhi
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
<PrevNextButton>takes the entire line by default. It should be inline instead of block<PrevNextButton>doesn't use the base Typography<PrevNextButton>adds useless markupSolution
Use
<Stack>with custom stylingThe change of inner class name is technically a breaking change, but I suggest to accept it because the feature is very recent and wasn't properly styled before.
Before
After