Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security vulnerability in dev dependencies due to outdated storybook #9374

Merged
merged 3 commits into from Oct 20, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Oct 20, 2023

babel/traverse has issued CVE-2023-45133, and Github has warned us about a possible vulneraility.

We only use this module via Storybook, which is only for development. The is no vulnerability for projects using react-admin.

Yet we're upgrading storybook to dismiss that alert.

yarn.lock Outdated
@@ -179,6 +196,29 @@ __metadata:
languageName: node
linkType: hard

"@babel/core@npm:^7.22.0, @babel/core@npm:^7.22.9":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some duplicate deps (e.g. @babel/core here). I'll try to run yarn dedupe to see if it helps.

@slax57 slax57 added this to the 4.15.1 milestone Oct 20, 2023
@slax57 slax57 merged commit ca0483f into master Oct 20, 2023
11 checks passed
@slax57 slax57 deleted the update-storybook branch October 20, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants