Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix total in useInfiniteGetList for empty results #9395

Merged
merged 2 commits into from Oct 26, 2023
Merged

Fix total in useInfiniteGetList for empty results #9395

merged 2 commits into from Oct 26, 2023

Conversation

KislyakovDS
Copy link
Contributor

@KislyakovDS KislyakovDS commented Oct 26, 2023 •
edited by fzaninotto

  • total should return 0 if the data is empty;

Closes #9388

@KislyakovDS
Fix for issue 9388:
543a1cd 
 - total should return 0 if the data is empty;
djhi
djhi requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/ra-core/src/controller/list/useInfiniteListController.spec.tsx Outdated
@@ -515,4 +515,36 @@ describe('useInfiniteListController', () => {
});
});
});

describe('checkTotalValue', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe('checkTotalValue', () => {

Not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

packages/ra-core/src/controller/list/useInfiniteListController.spec.tsx Show resolved Hide resolved
@KislyakovDS
Fix for issue 9388:
dc2c7e5 
 - remove test describe after review;
@fzaninotto fzaninotto changed the title Fix total in useInfiniteGetList for issue 9388: Fix total in useInfiniteGetList for empty results Oct 26, 2023
@fzaninotto fzaninotto merged commit 708792b into marmelab:master Oct 26, 2023
10 checks passed
@fzaninotto fzaninotto added this to the 4.15.2 milestone Oct 26, 2023
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.

useInfiniteGetList returns total as undefined, when real value equal to 0
3 participants
@KislyakovDS @fzaninotto @djhi