Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Allow to pass custom provider types to addRefreshAuth functions #9428

Merged
merged 1 commit into from Nov 8, 2023
Merged

[TypeScript] Allow to pass custom provider types to addRefreshAuth functions #9428

merged 1 commit into from Nov 8, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Nov 8, 2023 •
edited

Problem

When you have a custom dataProvider with custom methods, passing it to the addRefreshAuthToDataProvider method loose its type. Same for the addRefreshAuthToAuthProvider.

Solution

Declare a type parameter. You don't have to specify the type, it's inferred

@djhi djhi added the RFR Ready For Review label Nov 8, 2023
@fzaninotto fzaninotto merged commit f030350 into master Nov 8, 2023
11 checks passed
@fzaninotto fzaninotto deleted the allow-custom-providers-refresh-token-functions branch November 8, 2023 12:51
@fzaninotto fzaninotto added this to the 4.15.4 milestone Nov 8, 2023
@fzaninotto fzaninotto changed the title Allow to pass custom provider types to addRefreshAuth functions [TypeScript] Allow to pass custom provider types to addRefreshAuth functions Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.15.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhi @fzaninotto