Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fetchOptions to <CheckForApplicationUpdate> #9436

Merged
merged 13 commits into from Nov 13, 2023
Merged

Add support for fetchOptions to <CheckForApplicationUpdate> #9436

merged 13 commits into from Nov 13, 2023

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Nov 9, 2023

Fix issue in #9432

fzaninotto
fzaninotto requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! As this is a new feature, could you please PR against next instead?

docs/CheckForApplicationUpdate.md Outdated Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/CheckForApplicationUpdate.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/util/useCheckForApplicationUpdate.ts Outdated Show resolved Hide resolved
@smeng9 smeng9 changed the base branch from master to next November 10, 2023 19:02
@fzaninotto fzaninotto merged commit 9a3c3c8 into marmelab:next Nov 13, 2023
9 of 10 checks passed
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.15.5 milestone Nov 13, 2023
@slax57 slax57 changed the title Fix <CheckForApplicationUpdate> may check a stale copy in cache for update Add support for fetchOptions to <CheckForApplicationUpdate> Nov 14, 2023
@smeng9 smeng9 deleted the fix-app-update-fetch branch November 15, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.15.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smeng9 @fzaninotto