Introduce SourceContext #9533
Merged
Introduce SourceContext #9533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Dec 19, 2023
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.spec.tsx
Show resolved
Hide resolved
adguernier
approved these changes
Dec 20, 2023
adguernier
requested changes
Dec 20, 2023
adguernier
requested changes
Dec 20, 2023
fzaninotto
requested changes
Jan 3, 2024
packages/ra-ui-materialui/src/input/ArrayInput/ArrayInput.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIteratorItem.tsx
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIteratorItem.tsx
Show resolved
Hide resolved
slax57
requested changes
Jan 4, 2024
packages/ra-ui-materialui/src/input/TranslatableInputsTabContent.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/TranslatableInputs.spec.tsx
Outdated
Show resolved
Hide resolved
slax57
requested changes
Jan 8, 2024
packages/ra-ui-materialui/src/input/TranslatableInputsTabContent.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Jan 8, 2024
| ); | ||
| screen.getByText('Label for title'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think we're missing tests cases for sources with dots and / or inside ArrayInputs.
packages/ra-ui-materialui/src/input/TranslatableInputsTabContent.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
slax57
requested changes
Jan 11, 2024
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIteratorItem.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Jan 11, 2024
| ret = children({ formData, scopedFormData, getSource, ...rest }); | ||
| if (matches) { | ||
| const scopedFormData = get(formData, matches[0]); | ||
| ret = children({ formData, scopedFormData, ...rest }); |
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
fzaninotto
approved these changes
Jan 11, 2024
slax57
requested changes
Jan 11, 2024
packages/ra-ui-materialui/src/input/ArrayInput/ArrayInput.stories.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to prefix sources in multiple cases: ArrayInput + SimpleFormIterator, and many EE components.
To do that we currently clone children.
Solution
This is avoidable by introducing a context that useInput would use to set the source.
It’s a breaking change though for custom inputs that don’t use
useInput.