Fix usePreference should throw an error when used outside a <Configurable> context
#9537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adguernier
requested changes
Dec 21, 2023
| @@ -218,3 +218,8 @@ export const I18n = () => { | |||
| }; | |||
|
|
|||
| export const NotInContext = () => <TextBlock />; | |||
|
|
|||
| export const usePreferenceNotInConfigurable = () => { | |||
There was a problem hiding this comment.
Suggested change
| export const usePreferenceNotInConfigurable = () => { | |
| export const UsePreferenceOutsideConfigurable = () => { |
slax57
reviewed
Dec 21, 2023
docs/Configurable.md
Outdated
| @@ -58,7 +58,7 @@ const TextBlockEditor = () => { | |||
| ); | |||
| }; | |||
| ``` | |||
| This hook is only used within a Configurable component. | |||
There was a problem hiding this comment.
This line is redundant with the information given above. IMO it's not necessary to add it.
| @@ -218,3 +218,8 @@ export const I18n = () => { | |||
| }; | |||
|
|
|||
| export const NotInContext = () => <TextBlock />; | |||
|
|
|||
| export const usePreferenceNotInConfigurable = () => { | |||
There was a problem hiding this comment.
Suggested change
| export const usePreferenceNotInConfigurable = () => { | |
| export const UsePreferenceNotInConfigurable = () => { |
Not sure it's necessary to create a story for this corner-case though...
arimet
force-pushed
the
fix/usePreferences
branch
from
5563c60
to
bf44785
Compare
djhi
approved these changes
Dec 22, 2023
slax57
changed the title
usePreference should throw an error when used outside a <Configurable> context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #9526