-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove injected props in Admin and Layout components #9591
Merged
Merged
Commits on Jan 17, 2024
-
Update Layout to require only children prop
## Problem The Layout component is the last one requiring props cloning in user land: ```jsx // in src/MyLayout.js import { Layout } from 'react-admin'; import { MyAppBar } from './MyAppBar'; export const MyLayout = props => ( <Layout {...props} appBar={MyAppBar} /> ); ``` Developers wonder: what is props? Why do I have to pass it down? It’s not so usual in modern React. ## Solution Use a context instead, and just pass the children down (which requires no explaining). ```jsx // in src/MyLayout.js import { Layout } from 'react-admin'; import { MyAppBar } from './MyAppBar'; export const MyLayout = ({ children }) => ( <Layout appBar={MyAppBar}> {children} </Layout> ); ```
Configuration menu - View commit details
-
Copy full SHA for 6160f33 - Browse repository at this point
Copy the full SHA 6160f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d91906 - Browse repository at this point
Copy the full SHA 0d91906View commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1c1ea7 - Browse repository at this point
Copy the full SHA d1c1ea7View commit details
Commits on Jan 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26a1b88 - Browse repository at this point
Copy the full SHA 26a1b88View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2875af - Browse repository at this point
Copy the full SHA f2875afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 674d871 - Browse repository at this point
Copy the full SHA 674d871View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6e4272 - Browse repository at this point
Copy the full SHA a6e4272View commit details
Commits on Jan 23, 2024
-
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8813a1d - Browse repository at this point
Copy the full SHA 8813a1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c5fb1d - Browse repository at this point
Copy the full SHA 9c5fb1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 721ccca - Browse repository at this point
Copy the full SHA 721cccaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.