Remove list's setFilters default debounce #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Feb 25, 2024
| @@ -345,7 +345,7 @@ If you provided a React element for the optionText prop, you must also provide t | |||
| return; | |||
| } | |||
|
|
|||
| setFilters(filterToQuery(filter), undefined, true); | |||
There was a problem hiding this comment.
This didn't make sense as the call is debounced two lines earlier. The previous code caused a double debounce.
slax57
reviewed
Feb 26, 2024
adguernier
approved these changes
Feb 26, 2024
slax57
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
setFilterscallback returned byuseListControlleris debounced by default. This creates numerous WTF issues (e.g. #4189). This default makes sense for the Filter form/button combo, but not for the other filters.Besides, the
setFiltersreturned by other controllers (useList, etc) isn’t debounced by default.Solution
Make the
setFiltersdefault todebounce=false. Force the debounce inFilterForm.Also, revert #9639 as these explanations are no longer necessary