Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <SortButton> should use the provided resource prop to build its label #9694

Merged
merged 1 commit into from
Feb 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/ra-ui-materialui/src/button/SortButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,14 @@ const SortButton = (props: SortButtonProps) => {
icon = defaultIcon,
sx,
className,
resource: resourceProp,
} = props;
const { resource, sort, setSort } = useListSortContext();
const {
resource: resourceFromContext,
sort,
setSort,
} = useListSortContext();
const resource = resourceProp || resourceFromContext;
const translate = useTranslate();
const translateLabel = useTranslateLabel();
const isXSmall = useMediaQuery((theme: Theme) =>
Expand Down