Make all inputs fullWidth by default #9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Mar 8, 2024
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIteratorItem.tsx
Show resolved
Hide resolved
adguernier
reviewed
Mar 12, 2024
packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/input/TranslatableInputs.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/filter/FilterLiveSearch.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: adrien guernier <adrien@marmelab.com>
Co-authored-by: adrien guernier <adrien@marmelab.com>
|
Review applied |
adguernier
reviewed
Mar 13, 2024
erwanMarmelab
approved these changes
Mar 13, 2024
adguernier
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MUI doesn't define a consistent input width, and neither do we. As a consequence, forms mixing various input types don't show a proper alignment by default.
See this story for an illustration. Refs #8796.
Solution
Make all inputs full width by default
The 'all inputs' story has been updated to let the user test all existing themes, as well as an empty theme (default MUI) and a compat theme (to get the same input widths as in react-admin v4).
As a result, building custom form layouts with Stack and Grid is faster, as we don't have to set
fullWidthmanually in all inputs (see the changeset for the react-admin demos).This change is easily reversible for existing apps using a custom theme.
Supersedes #9686