Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit / show title prop: add 'false' and callback choices #9769

Closed
wants to merge 42 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
267e755
Add server side validation support
djhi Jul 7, 2022
f96df58
Fix tests
djhi Jul 7, 2022
fa7b88d
Apply changes after review
djhi Jul 7, 2022
0625ac2
Apply review comments
djhi Jul 29, 2022
df1da58
Introduce withRefreshAuth
djhi Jan 13, 2023
9e65692
Merge remote-tracking branch 'origin/next' into refresh-auth-hof
slax57 Feb 15, 2023
7c6d62c
code review changes
slax57 Feb 15, 2023
bb4ed6e
Merge remote-tracking branch 'origin/next' into refactor-saving-status
slax57 Feb 15, 2023
26ba43d
code review
slax57 Feb 15, 2023
71fa7de
fix doc about translation objects support
slax57 Feb 15, 2023
ba28552
fix E2E test
slax57 Feb 15, 2023
6003c33
Apply suggestions from code review
slax57 Feb 20, 2023
423e886
Allow to customize how `<FilterListItem>` applies filters
djhi Feb 22, 2023
e5774fe
Add documentation
djhi Feb 22, 2023
39627b1
Add a screencast showing cumulative filters
djhi Feb 23, 2023
01cb255
Fix typos
djhi Feb 23, 2023
835a128
Improve tests
djhi Feb 23, 2023
cbc1466
Refactor test
djhi Feb 23, 2023
6515dd1
Improve AppBar features and documentation
fzaninotto Feb 23, 2023
74334bb
Improve AppBar Doc
fzaninotto Feb 24, 2023
88bddc3
Fix missing TitlePortal in JSDoc
fzaninotto Feb 24, 2023
789858b
Fix tests
fzaninotto Feb 24, 2023
662f57e
Apply suggestions from code review
fzaninotto Feb 24, 2023
22844ae
Update FilterList documentation
djhi Feb 24, 2023
03c8bac
Mention server validation only works in pessimistic mode
djhi Feb 24, 2023
78a3567
Merge pull request #8676 from marmelab/allow-filter-list-item-customi…
slax57 Feb 24, 2023
c49228b
Merge pull request #7938 from marmelab/refactor-saving-status
slax57 Feb 24, 2023
4389dc8
Update authentication introduction
djhi Feb 24, 2023
6b96b79
Fix link
djhi Feb 24, 2023
c69c86f
Merge pull request #8574 from marmelab/refresh-auth-hof
slax57 Feb 24, 2023
6a4e716
Add images
fzaninotto Feb 24, 2023
dcf5ab7
Typo fixes
fzaninotto Feb 25, 2023
8c4b129
Fix outdated usage of AppBar in the doc
fzaninotto Feb 26, 2023
88a7276
Add doc for Title component
fzaninotto Feb 26, 2023
6e9ac1a
Fix configurable title outline
fzaninotto Feb 26, 2023
299a325
Fix typo
fzaninotto Feb 26, 2023
222d205
Add screencast for configurable mode
fzaninotto Feb 26, 2023
062a57c
Merge pull request #8681 from marmelab/appbar-improvements
djhi Feb 27, 2023
21e1e8b
Modifiable size for selectArray input
amilosmanli Mar 11, 2023
da67d5c
Merge pull request #8562 from amilosmanli/modifiable-select-array-input
slax57 Mar 13, 2023
de8c1b3
edit / show title prop: add 'false' and callback choices
hiaselhans Apr 10, 2024
b950109
run linter
hiaselhans Apr 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/edit.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ describe('Edit Page', () => {
cy.get('body').click('left'); // dismiss notification

cy.get('div[role="alert"]').should(el =>
expect(el).to.have.text('this title cannot be used')
expect(el).to.have.text('The form is invalid')
);

cy.get(ListPagePosts.elements.recordRows)
Expand Down
4 changes: 2 additions & 2 deletions docs/Admin.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ const App = () => (

## `dashboard`

By default, the homepage of an admin app is the `list` of the first child `<Resource>`. But you can also specify a custom component instead. To fit in the general design, use MUI's `<Card>` component, and react-admin's `<Title>` component to set the title in the AppBar:
By default, the homepage of an admin app is the `list` of the first child `<Resource>`. But you can also specify a custom component instead. To fit in the general design, use MUI's `<Card>` component, and [react-admin's `<Title>` component](./Title.md) to set the title in the AppBar:

```jsx
// in src/Dashboard.js
Expand Down Expand Up @@ -270,7 +270,7 @@ When users type URLs that don't match any of the children `<Resource>` component

![Not Found](./img/not-found.png)

You can customize this page to use the component of your choice by passing it as the `catchAll` prop. To fit in the general design, use MUI's `<Card>` component, and react-admin's `<Title>` component:
You can customize this page to use the component of your choice by passing it as the `catchAll` prop. To fit in the general design, use MUI's `<Card>` component, and [react-admin's `<Title>` component](./Title.md):

```jsx
// in src/NotFound.js
Expand Down