Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to customize the success notification message in delete buttons #9868

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Add ability to customize the success notification message in delete buttons #9868

merged 6 commits into from
Jul 9, 2024

Conversation

ethembynkr
Copy link

@ethembynkr ethembynkr commented May 22, 2024 •
edited by slax57
Loading

Closes #9837

@ethembynkr ethembynkr mentioned this pull request May 25, 2024
Closed
@slax57
Copy link
Contributor

slax57 commented May 27, 2024

As is is a new feature, it needs to target the next branch. React Admin v4 is feature-freeze as we are in the verge of releasing React Admin v5. This feature will hence have to be released in v5.
Can you rebase onto next?

@ethembynkr ethembynkr changed the base branch from master to next May 27, 2024 12:01
@ethembynkr
Copy link
Author

Hi @slax57. I changed target branch to next. Can you review?

@fzaninotto
Copy link
Member

Thanks for your PR. Could you please add unit tests?

@ethembynkr
Added unit tests for successMessage in useDeleteWithConfirmController…
75d5616 
…, useDeleteWithConfirmController, BulkDeleteWithConfirmButton, BulkDeleteWithUndoButton, DeleteWithConfirmButton and DeleteWithUndoButton.
@ethembynkr
Copy link
Author

I've added unit tests.

slax57
slax57 requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, the code looks good, thanks for the PR!

packages/ra-core/src/controller/button/useDeleteWithUndoController.spec.tsx Outdated Show resolved Hide resolved
@ethembynkr ethembynkr requested a review from slax57 July 1, 2024 17:07
slax57
slax57 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!
Sorry for taking so long to review... 😬

@slax57 slax57 added this to the 5.1.0 milestone Jul 9, 2024
@slax57 slax57 merged commit 0ac5884 into marmelab:next Jul 9, 2024
13 checks passed
@slax57 slax57 changed the title customising success message in delete with confirm Add ability to customize the success notification message in delete buttons Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Customising the message that appears after the delete operation in DeleteWithConfirmButton
3 participants
@ethembynkr @slax57 @fzaninotto