Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update <SelectArrayInput> to use default record representation when used inside <ReferenceArrayInput> #9902

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Update <SelectArrayInput> to use default record representation when used inside <ReferenceArrayInput> #9902

merged 6 commits into from
Jun 6, 2024

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jun 5, 2024

This input didn't leverage recordRepresentation for the choices texts.

@djhi djhi added the RFR Ready For Review label Jun 5, 2024
@fzaninotto fzaninotto changed the title Use record representation in <SelectArrayInput> Update <SelectArrayInput> to use default record representation when used inside <ReferenceArrayInput> Jun 5, 2024
fzaninotto
fzaninotto requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the <SelectArrayInput> doc? We currently have the following in <SelectInput>:

image

packages/ra-ui-materialui/src/input/SelectArrayInput.stories.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/SelectArrayInput.stories.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/SelectArrayInput.stories.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/SelectArrayInput.spec.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/SelectArrayInput.spec.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/SelectArrayInput.spec.tsx Outdated Show resolved Hide resolved
@djhi @fzaninotto
Apply suggestions from code review
912f02f 
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
@djhi
Copy link
Contributor Author

djhi commented Jun 5, 2024 •
edited
Loading

Could you also update the <SelectArrayInput> doc? We currently have the following in <SelectInput>:

image

Actually, the documentation already mentioned the recordRepresentation even though it wasn't implemented ^^:

https://marmelab.com/react-admin/SelectArrayInput.html#optiontext

@adguernier adguernier self-requested a review June 5, 2024 15:48
@adguernier adguernier added this to the 5.0.0 milestone Jun 6, 2024
@adguernier adguernier merged commit 67c3b10 into next Jun 6, 2024
14 checks passed
@adguernier adguernier deleted the select-array-input-record-representation branch June 6, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@adguernier adguernier adguernier approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.0.0-rc.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djhi @fzaninotto @adguernier