App extension safe API #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used the 'Update' dialog in Xcode 8.1 to update the project to the recommended settings. - Set the Swift version to be 3.0.1
Since there is no API used by the Library that is not extension safe, its safe to switch this on which will prevent warnings if one uses this framework in an App extension
|
Thanks a lot @leoMehlig and sorry for the delay. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this project in an App extension and always got the warning that this library isn't App extension safe.
Since the code doesn't reference any non App Extension safe APIs, it is safe to enable this.
I also updated the project settings to the recommended settings in Xcode 8.1