Adding localized with format function #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure whether or not the withFormat functions were useful but I like the idea of adding them back. The pull request looks good to me but I'll need you to resolve the conflicts with the head branch before I can merge though. |
|
Oops, I've been using the outdated library 😲 I only changed Localized.swift file and genstrings.py file, so other things will be fine. |
|
Thanks. Let's merge. I'll include your code in the next release (later this week). |
marmelroy
added a commit
that referenced
this pull request
Nov 23, 2015
Adding localized with format function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using your library really useful.
However, why did you remove the localizedWithFormat feature? It is really useful in practical app development.