Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More swifty naming ? #2

Closed
alikaragoz opened this issue Nov 15, 2016 · 1 comment
Closed

More swifty naming ? #2

alikaragoz opened this issue Nov 15, 2016 · 1 comment

Comments

@alikaragoz
Copy link
Collaborator

This is not an exhaustive list of course but I think this project should benefit from more concise and compact naming à la Swift 3.0.

Before After
let ivars = mapViewClass.allIvars() let ivars = mapViewClass.vars()
let selectors = mapViewClass.allSelectors() let selectors = mapViewClass.selectors()
let properties = mapViewClass.allProperties() let properties = mapViewClass.properties()
let protocols = mapViewClass.allProtocols() let protocols = mapViewClass.protocols()
viewClass.addSelectorToClass(...) viewClass.addSelector(...)
viewClass.addMethodToClass(...) viewClass.addMethod(...)

I've spotted a few other places where this can be applied. What do you think ?

marmelroy added a commit that referenced this issue Nov 15, 2016
marmelroy added a commit that referenced this issue Nov 15, 2016
@marmelroy
Copy link
Owner

Thanks @alikaragoz. Great suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants