Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate call fix #695

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Delegate call fix #695

merged 1 commit into from
Sep 19, 2023

Conversation

mihail-jdanov
Copy link
Contributor

@mihail-jdanov mihail-jdanov commented Sep 15, 2023

Steps to reproduce the bug:

  1. Create PhoneNumberTextField instance and set it's delegate
  2. Tap text field and press space
  3. "shouldChangeCharactersIn" method of delegate should be called, but it doesn't

@bguidolim
Copy link
Collaborator

Have you tested with the autofill feature?

@mihail-jdanov
Copy link
Contributor Author

Yes, autofill feature works

@bguidolim
Copy link
Collaborator

Thank you!
I'll review it soon

@bguidolim bguidolim merged commit df90c8a into marmelroy:master Sep 19, 2023
2 checks passed
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Sep 20, 2023
….1" (#598)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[marmelroy/PhoneNumberKit](https://togithub.com/marmelroy/PhoneNumberKit)
| minor | `from: "3.6.8"` -> `from: "3.7.1"` |

---

### Release Notes

<details>
<summary>marmelroy/PhoneNumberKit (marmelroy/PhoneNumberKit)</summary>

###
[`v3.7.1`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.7.1)

[Compare
Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.7.0...3.7.1)

#### What's Changed

- Fix wrong access level for country picker UI options by
[@&#8203;bguidolim](https://togithub.com/bguidolim) in
[marmelroy/PhoneNumberKit#700

**Full Changelog**:
marmelroy/PhoneNumberKit@3.7.0...3.7.1

###
[`v3.7.0`](https://togithub.com/marmelroy/PhoneNumberKit/releases/tag/3.7.0)

[Compare
Source](https://togithub.com/marmelroy/PhoneNumberKit/compare/3.6.8...3.7.0)

#### What's Changed

- Delegate call fix by
[@&#8203;mihail-jdanov](https://togithub.com/mihail-jdanov) in
[marmelroy/PhoneNumberKit#695
- Customize CountryCodePickerViewController by
[@&#8203;jvitor](https://togithub.com/jvitor) in
[marmelroy/PhoneNumberKit#697
- Release 3.7.0 by [@&#8203;bguidolim](https://togithub.com/bguidolim)
in
[marmelroy/PhoneNumberKit#698

#### New Contributors

- [@&#8203;mihail-jdanov](https://togithub.com/mihail-jdanov) made their
first contribution in
[marmelroy/PhoneNumberKit#695
- [@&#8203;jvitor](https://togithub.com/jvitor) made their first
contribution in
[marmelroy/PhoneNumberKit#697

**Full Changelog**:
marmelroy/PhoneNumberKit@3.6.8...3.7.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants