Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift version to 4.1 for Xcode 9.3. #135

Merged
merged 1 commit into from Jun 15, 2018
Merged

Update swift version to 4.1 for Xcode 9.3. #135

merged 1 commit into from Jun 15, 2018

Conversation

chris-guidry
Copy link
Contributor

After upgrading to Xcode 9.3, I got the following error:
dyld: Library not loaded: @rpath/libswiftCore.dylib
Referenced from: /Users/chris/Library/Developer/CoreSimulator/Devices/.../data/Containers/Bundle/Application/.../RE-vibe.app/Frameworks/Zip.framework/Zip
Reason: image not found

To fix the error, I needed to update the Build Setting "Always Embed Swift Standard Libraries" to Yes, and update the swift version for this package to 4.1, which matches Xcode 9.3's version.

After upgrading to Xcode 9.3, I get the following error:
dyld: Library not loaded: @rpath/libswiftCore.dylib
  Referenced from: /Users/chris/Library/Developer/CoreSimulator/Devices/.../data/Containers/Bundle/Application/.../RE-vibe.app/Frameworks/Zip.framework/Zip
  Reason: image not found

I have tried several different approaches, but none have fixed the issue. I suspect the the swift version for this package needs to be upgraded to match Xcode 9.3's version.
Copy link
Collaborator

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're mentioning the Always Embed Swift Standard Libraries change, but this is not reflected in the pull request.

What is the reason for it to not be pushed as a change?

@chris-guidry
Copy link
Contributor Author

@AvdLee - the build setting I changed is part of the XCode project, and not specific to the zip library. I mentioned it so that other folks would know both steps which were required for it to work. Is there a setting somewhere in the library that is related and should be changed?

@AvdLee
Copy link
Collaborator

AvdLee commented Jun 15, 2018

@chris-guidry no, I think this is good enough!

@AvdLee AvdLee merged commit 66dfbc2 into marmelroy:master Jun 15, 2018
@chris-guidry chris-guidry deleted the patch-1 branch June 15, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants