Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node and dependent packages to the latest version #191

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Dec 13, 2019

This PR will upgrade Node LTS and dependent packages to the latest version via yarn upgrade --latest.

Notable changes

Node

Dependent packages

  • Resolve vulnerability in deep deps: rollup-plugin-terser > serialize-javascript (CVE-2019-16769)
  • Migration of rollup official plugins into monorepo is still in progress.
    • rollup-plugin-node-resolve => @rollup/plugin-node-resolve
    • rollup-plugin-url => @rollup/plugin-url
  • rollup-plugin-url v3 has been dropped Node 8 support so Marp CLI could not bump it (by failing CI test for against Node 8). But the migrated plugin @rollup/plugin-url v4 is getting back the support of Node 8.
    • However, Node 8 would reach EOL in the end of this year. In next month, Marp CLI also will drop Node 8 support.
  • Modify deprecated Puppeteer method page.emulateMedia in favor of page. emulateMediaType.

@yhatt yhatt merged commit 2eb4a34 into master Dec 13, 2019
@yhatt yhatt deleted the upgrade-node-and-dependencies branch December 13, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant