Add missing local file error message #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
reviewed
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this great CLI.
Problem
Currently, when
allowLocalFilesis set totrueand some local files are missing, marp-cli issuesMarp CLI has detected accessing to local file. That is blocked by security reason. Instead we recommend using assets uploaded to online.warning. This message is confusing because users are told to setallowLocalFilesto true even though they've already done so.Solution
Adding new error message that indicates some local files are missing would be very helpful. In this PR, I propose the error message
Marp CLI has detected accessing to local file that does not exist.