Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Support opening preview window provided by Carlo #44

Merged
merged 12 commits into from Dec 6, 2018

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Dec 5, 2018

Support an experimental --preview option to open a preview window provided by Carlo. Marp CLI can open a mini window to show a preview of editing Markdown by using Chrome instance.

preview

preview2

If you turned on --preview option, --watch option is enabled automatically too. It would provide a better experience while writing the Marp presentation in your favorite editor as like as Deckset.

Of course you can use it to the actual presentation by maximize window.

Restrictions

It is marked as an experimental support because of some restrictions.

  • Marp CLI is still supporting Node v6, but Carlo is not supported, requires Node >= 7. You can not use --preview option if Marp CLI is running in Node 6.
  • --preview is available only together with --server option. For regular conversion, we need to handle multiple windows against found files specified by file paths, glob, and --input-dir option.

Tasks

for this PR

  • Add tests

In future

  • --preview option for regular conversion
    • Handle multiple files
  • -p alias
  • Toggle some features
    • Fullscreen
    • Always on top (It might be impossible currently)

@yhatt yhatt merged commit b72d87a into master Dec 6, 2018
@yhatt yhatt deleted the experimental-preview branch December 6, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant