Upgrade Node and dependent packages to latest #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Jan 20, 2019
package.json
Outdated
| @@ -121,5 +121,8 @@ | |||
| "tmp": "^0.0.33", | |||
| "ws": "^6.1.2", | |||
| "yargs": "^12.0.5" | |||
| }, | |||
| "resolutions": { | |||
| "dir-glob": "2.0.0" | |||
There was a problem hiding this comment.
By downgrading dir-glob from v2.2.0 to v2.0.0, failed tests caused by globby are fixed.
Perhaps the updated dir-glob cannot handle passed absolute path.
https://github.com/kevva/dir-glob/blob/3cd414fc3694dbaf9f87892febadf5703a6475ea/index.js#L6
There was a problem hiding this comment.
I've reported to kevva/dir-glob#15. And now I started working to resolve this on forked repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Node and dependent packages to latest version by using
yarn upgrade(-interactive) --latest.This PR is included the update of Marpit v0.6.0 and Marp Core v0.5.0.
There is a major upgrade in globby 8.x => 9.x,
and currently it brings to fail tests.UPDATE: I've reported a regression of dir-glob to kevva/dir-glob#15, and it was fixed by author's quick working.